Skip to content

UPSTREAM PR #17975: common : skip model validation when --completion-bash is requested#539

Open
loci-dev wants to merge 1 commit intomainfrom
upstream-PR17975-branch_ggml-org-cisc/skip-model-validation-completion-bash
Open

UPSTREAM PR #17975: common : skip model validation when --completion-bash is requested#539
loci-dev wants to merge 1 commit intomainfrom
upstream-PR17975-branch_ggml-org-cisc/skip-model-validation-completion-bash

Conversation

@loci-dev
Copy link

Mirrored from ggml-org/llama.cpp#17975

cont #17755

Fixes #17973

@loci-review
Copy link

loci-review bot commented Dec 12, 2025

Explore the complete analysis inside the Version Insights

Performance Analysis Summary

Project: llama.cpp
Version Comparison: a2f0b5fe-7aa0-41c3-9430-ddfb152bd6cc vs f01dd79b-dbbc-495f-80e0-e5faae90f8ed


Analysis Result

Condition 1 Applied: No Meaningful Performance Impact

This PR modifies a single conditional statement in common/arg.cpp to skip model validation when --completion-bash is requested. The change adds one boolean check (!params.completion) to the startup validation logic, executed once per application launch. No functions in the inference pipeline (llama_decode, llama_encode, llama_tokenize) are affected. Power consumption remains unchanged across all binaries (0.0% change). Token generation throughput is unaffected.

@loci-dev loci-dev force-pushed the main branch 27 times, most recently from f251487 to 752a7d5 Compare December 16, 2025 10:10
@loci-dev loci-dev force-pushed the main branch 30 times, most recently from fef1737 to cc6b7b1 Compare December 21, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants